Skip to content

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 6, 2021

For #8372 Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/125

  • Add caching to command output in discovery component. When the extension is starting up sometimes the same commands are run again and again, hence cache for more duration during startup.
  • Poetry commands can be slow and so can be bottleneck to overall discovery time. So trigger command execution as soon as possible. To do that we need to ensure the operations before the command are performed synchronously.
  • Get python executables using getInterpreterPathFromDir instead of finding interpreters in all directories.

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary labels Apr 6, 2021
@karrtikr karrtikr changed the title Add caching to command output in discovery component Make poetry discovery faster Apr 6, 2021
@karrtikr karrtikr marked this pull request as ready for review April 6, 2021 22:42
@karrtikr karrtikr merged commit a30900f into microsoft:main Apr 7, 2021
@karrtikr karrtikr deleted the poetryoptimize branch April 7, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants