Skip to content

Conversation

karthiknadig
Copy link
Member

Looks like i accidentally did not merge the change log back from release. Fixed that here.

@karthiknadig karthiknadig requested a review from rchiodo April 8, 2021 21:19
([#15580](https://github.com/Microsoft/vscode-python/issues/15580))
1. Ensure that jedi language server uses jedi shipped with the extension.
([#15586](https://github.com/Microsoft/vscode-python/issues/15586))
1. Updates to Proposed API, and fix the failure in VS Code Insider tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Python release aligned with VS Code's stable release cycle? This fix that I made here to unblock insiders was only checked into VS Code main 13 days ago, so it's only live on insiders and not on stable yet. I might have to adjust this to handle either the old API or the new API if this goes live before then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our release is not aligned with VS Code's release cycle. So I guess we need this fix before we release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luabud Yeah, sorry about the complication here. Given that we want to keep main running with insiders builds I think that splitting off release is still fine. I'll just have to make a fix directly into the release branch for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanMatthewHuff sounds good, thank you!! 😊

@karthiknadig karthiknadig merged commit 84d798f into microsoft:main Apr 8, 2021
@karthiknadig karthiknadig deleted the release-prep branch April 8, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants