Skip to content

Update tests: vscode.notebook.activeNotebookEditor --> vscode.window.activeNotebookEditor #16381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Update tests: vscode.notebook.activeNotebookEditor --> vscode.window.activeNotebookEditor #16381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5cdf95
vscode.window.activeNotebookEditor
joyceerhl Jun 3, 2021
df83d5e
window.visibleNotebookEditors
joyceerhl Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/test/initialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export async function closeActiveNotebooks(): Promise<void> {
}
// We could have untitled notebooks, close them by reverting changes.

while ((vscode as any).notebook.activeNotebookEditor || vscode.window.activeTextEditor) {
while ((vscode as any).window.activeNotebookEditor || vscode.window.activeTextEditor) {
await vscode.commands.executeCommand('workbench.action.revertAndCloseActiveEditor');
}
// Work around VS Code issues (sometimes notebooks do not get closed).
Expand Down Expand Up @@ -102,10 +102,10 @@ async function closeWindowsInteral() {

function isANotebookOpen() {
if (
Array.isArray((vscode as any).notebook.visibleNotebookEditors) &&
(vscode as any).notebook.visibleNotebookEditors.length
Array.isArray((vscode as any).window.visibleNotebookEditors) &&
(vscode as any).window.visibleNotebookEditors.length
) {
return true;
}
return !!(vscode as any).notebook.activeNotebookEditor;
return !!(vscode as any).window.activeNotebookEditor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another .notebook just above this one that also needs changing.

}