Fix go to definition in Python notebooks (#16385) #16448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* notebook renamed to notebooks, notebooks symbols moved to workspace namespace * Drop usage of NotebookCellMetadata ctor
|
@karrtikr was thinking I'd just update the CHANGELOG directly, but I can also do the news entry and then your team can put that into the CHANGELOG in a separate PR? Whichever y'all prefer |
…ow.activeNotebookEditor` (#16381) * vscode.window.activeNotebookEditor * window.visibleNotebookEditors
|
Oh I didn't notice this is the release branch. It's fine to edit the changelog then. |
karthiknadig
approved these changes
Jun 10, 2021
joyceerhl
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff and
rchiodo
IanMatthewHuff
approved these changes
Jun 10, 2021
|
@IanMatthewHuff yes:
The build I have is from a CI run on this PR (number is different than any of the ones that have been published to marketplace):
|
|
There's a venv test failure on this PR, I'm trying to identify whether it's related to these changes or also a problem on the main branch. |
|
The test failure (Windows venv) is also present on main. @karthiknadig can this PR be merged? |
|
Merged per conversation with Karthik on Teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point fix for language server support in the Python extension in VS Code Stable 1.57.0. This fix was submitted to main but needed to be included in a hotfix release.