-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a flag for autoselection #16923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag for autoselection #16923
Conversation
It's a rather small change, I'm going to merge it in 24 hours unless you have blocking concerns. |
} | ||
|
||
private getAutoSelectionInterpretersQueryState(): IPersistentState<boolean | undefined> { | ||
const key = `autoSelectionInterpretersQueried`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be workspace folder based key, similar to getWorkspaceState()
. In a multiroot scenario, we want to ensure we use ignoreCache
as true
for each workspace folder in the current workspace.
But I think the code here says that we only use ignoreCache
as true
once for the entire workspace, which is not what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember if using createWorkspacePersistentState
is enough to differentiate between workspaces in a multiroot scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but if it's referring to the workspace, and not the workspace folder as the name suggests, it's not enough.
Closes #16735