Skip to content

Conversation

kimadeline
Copy link

Closes #16735

@kimadeline kimadeline added the skip package*.json package.json and package-lock.json don't both need updating label Aug 11, 2021
@kimadeline kimadeline marked this pull request as ready for review August 11, 2021 20:21
@kimadeline
Copy link
Author

It's a rather small change, I'm going to merge it in 24 hours unless you have blocking concerns.

}

private getAutoSelectionInterpretersQueryState(): IPersistentState<boolean | undefined> {
const key = `autoSelectionInterpretersQueried`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be workspace folder based key, similar to getWorkspaceState(). In a multiroot scenario, we want to ensure we use ignoreCache as true for each workspace folder in the current workspace.

But I think the code here says that we only use ignoreCache as true once for the entire workspace, which is not what we want.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember if using createWorkspacePersistentState is enough to differentiate between workspaces in a multiroot scenario?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but if it's referring to the workspace, and not the workspace folder as the name suggests, it's not enough.

@kimadeline kimadeline requested a review from karrtikr August 11, 2021 22:46
@kimadeline kimadeline merged commit 462e069 into microsoft:main Aug 12, 2021
@kimadeline kimadeline deleted the 16735-autoselection-flag branch August 12, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not run auto-selection unnecessarily

3 participants