Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
"files.exclude": {
"out": true, // set this to true to hide the "out" folder with the compiled JS files
"dist": true,
"**/*.pyc": true,
".nyc_output": true,
"obj": true,
Expand All @@ -15,6 +16,7 @@
},
"search.exclude": {
"out": true, // set this to false to include "out" folder in search results
"dist": true,
"**/node_modules": true,
"coverage": true,
"languageServer*/**": true,
Expand Down
10 changes: 9 additions & 1 deletion build/webpack/webpack.extension.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,15 @@ const config = {
},
],
},
externals: ['vscode', 'commonjs', ...existingModulesInOutDir],
externals: [
'vscode',
'commonjs',
...existingModulesInOutDir,
// These dependencies are ignored because we don't use them, and App Insights has try-catch protecting their loading if they don't exist
// See: https://github.com/microsoft/vscode-extension-telemetry/issues/41#issuecomment-598852991
'applicationinsights-native-metrics',
'@opentelemetry/tracing',
],
plugins: [...common.getDefaultPlugins('extension')],
resolve: {
alias: {
Expand Down
6 changes: 5 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,11 @@ function getAllowedWarningsForWebPack(buildConfig) {
'WARNING in ./node_modules/applicationinsights/out/AutoCollection/NativePerformance.js',
];
case 'browser':
return [];
return [
'WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).',
'WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.',
'WARNING in webpack performance recommendations:',
];
default:
throw new Error('Unknown WebPack Configuration');
}
Expand Down
1 change: 1 addition & 0 deletions news/3 Code Health/16871.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update telemetry client to support browser, plumb to Pylance.
1 change: 1 addition & 0 deletions news/3 Code Health/16872.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Refactor language server middleware to work in the browser.
87 changes: 3 additions & 84 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2017,7 +2017,7 @@
"untildify": "^3.0.2",
"vscode-debugadapter": "^1.28.0",
"vscode-debugprotocol": "^1.28.0",
"vscode-extension-telemetry": "0.1.4",
"vscode-extension-telemetry": "0.2.8",
"vscode-jsonrpc": "6.0.0",
"vscode-jupyter-lsp-middleware": "^0.1.3",
"vscode-languageclient": "7.0.0",
Expand Down
Loading