Skip to content

Skip flaky tests #17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Skip flaky tests #17142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7b87d6
Skip conda env test
karthiknadig Aug 27, 2021
2ec0ccf
Use timeout in watcher tests
karthiknadig Aug 27, 2021
0e9943d
Increase watcher timeout
karthiknadig Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...est/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ suite('Activation of Environments in Terminal', () => {
test('Should activate with virtualenv', async () => {
await testActivation(envPaths.virtualEnvPath);
});
test('Should activate with conda', async () => {
test('Should activate with conda', async function () {
this.skip();
// Powershell does not work with conda by default, hence use cmd.
await terminalSettings.update(
'integrated.defaultProfile.windows',
Expand Down
8 changes: 4 additions & 4 deletions src/test/pythonEnvironments/base/locators/lowLevel/watcherTestUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export function testLocatorWatcher(
locator.onChanged(onChanged);
await getEnvs(locator.iterEnvs()); // Force the FS watcher to start.
// Wait for watchers to get ready
await sleep(1000);
await sleep(2000);
}

teardown(async () => {
Expand Down Expand Up @@ -203,7 +203,7 @@ export function testLocatorWatcher(
externalDeps.arePathsSame(actualEvent!.searchLocation!.fsPath, path.dirname(envDir)),
'Wrong event emitted',
);
});
}).timeout(TEST_TIMEOUT * 2);

test('Detect when an environment has been deleted', async () => {
let actualEvent: PythonEnvsChangedEvent;
Expand Down Expand Up @@ -237,7 +237,7 @@ export function testLocatorWatcher(
externalDeps.arePathsSame(actualEvent!.searchLocation!.fsPath, path.dirname(envDir)),
'Wrong event emitted',
);
});
}).timeout(TEST_TIMEOUT * 2);

test('Detect when an environment has been updated', async () => {
let actualEvent: PythonEnvsChangedEvent;
Expand All @@ -264,5 +264,5 @@ export function testLocatorWatcher(
externalDeps.arePathsSame(actualEvent!.searchLocation!.fsPath, path.dirname(envDir)),
`Paths don't match ${actualEvent!.searchLocation!.fsPath} != ${path.dirname(envDir)}`,
);
});
}).timeout(TEST_TIMEOUT * 2);
}