Skip to content

Set storage drive before changing directory on windows #17875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2021
Merged

Set storage drive before changing directory on windows #17875

merged 5 commits into from
Oct 29, 2021

Conversation

afikrim
Copy link

@afikrim afikrim commented Oct 28, 2021 •
edited by karrtikr
Loading

Hi! I create a pull request to fix issue #14730
Please review my PR, thanks.

Closes #14730

@ghost
Copy link

ghost commented Oct 28, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@karrtikr karrtikr self-requested a review October 29, 2021 00:23
karrtikr
karrtikr approved these changes Oct 29, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR (almost), thanks!

@afikrim
Copy link
Author

afikrim commented Oct 29, 2021

Thanks for the review, I'll check my codes again

@afikrim
Copy link
Author

afikrim commented Oct 29, 2021

I have changed my codes as mentioned above

@afikrim afikrim requested a review from karrtikr October 29, 2021 10:02
karrtikr
karrtikr reviewed Oct 29, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through my comments.

@afikrim afikrim requested a review from karrtikr October 29, 2021 19:19
@afikrim
Copy link
Author

afikrim commented Oct 29, 2021

I tried to add a new test for this,
Ensure we do not change drive if current drive letter is same as the file drive letter on windows

And update current test from workspace.getWorkspaceFolder to workspace.rootPath

karrtikr
karrtikr approved these changes Oct 29, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr merged commit c1d0fae into microsoft:main Oct 29, 2021
@afikrim afikrim deleted the afikrim/set-drive-before-dir-windows branch October 31, 2021 08:37
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@wesm
Set storage drive before changing directory on windows (microsoft/vsc…
3649b90 
…ode-python#17875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python.terminal.executeInFileDir doesn't work if file is on another drive from working directory

2 participants

@afikrim @karrtikr