Skip to content

Cherry fixes for point release #19996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2022
Merged

Cherry fixes for point release #19996

merged 3 commits into from
Oct 12, 2022

Conversation

karrtikr
Copy link

No description provided.

Kartik Raj added 2 commits October 12, 2022 17:27
Revert to using conda run for fetching activated environment variab…
d1126d5 
…les (#19986)

Reverts #19819 Closes
#19967

Until we have a better activation story:
#11039, where we
potentially get rid of using `conda activate` commands, use `conda run`
for fetching environment variables even though it's slower.

Created #19987 for
tackling it in the future.

FYI @DonJayamanne
Bump version
9b4f8be
@karrtikr karrtikr requested a review from karthiknadig October 12, 2022 17:30
@karrtikr karrtikr added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels Oct 12, 2022
@karthiknadig
Copy link
Member

@karrtikr Can you run npm install?

@karrtikr
Copy link
Author

@karthiknadig Sorry, done.

@karrtikr karrtikr removed the skip package*.json package.json and package-lock.json don't both need updating label Oct 12, 2022
@karrtikr karrtikr merged commit 347094f into release/2022.16 Oct 12, 2022
@karrtikr karrtikr deleted the kartik/chery branch October 12, 2022 18:18
@viviansmlie
Copy link

where is .vsix?

@karthiknadig
Copy link
Member

@viviansmlie You can get it from marketplace. https://marketplace.visualstudio.com/items?itemName=ms-python.python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required skip tests Updates to tests unnecessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karrtikr @karthiknadig @viviansmlie