Skip to content

Allow pytest to use correct interpreter from getActiveInterpreter #24250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Allow pytest to use correct interpreter from getActiveInterpreter #24250

merged 1 commit into from
Oct 4, 2024

Conversation

anthonykim1
Copy link

Resolves: #24122
Related: #24190, #24127

I think the culprit was we were not passing in interpreter when we call createActivatedEnvironment.

@anthonykim1 anthonykim1 mentioned this pull request Oct 4, 2024
Closed
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-environments Features relating to handling interpreter environments skip tests Updates to tests unnecessary labels Oct 4, 2024
@anthonykim1 anthonykim1 self-assigned this Oct 4, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review October 4, 2024 19:12
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 4, 2024
@anthonykim1 anthonykim1 merged commit 8c4dee4 into microsoft:main Oct 4, 2024
42 of 46 checks passed
@anthonykim1 anthonykim1 mentioned this pull request Oct 4, 2024
Closed
karthiknadig pushed a commit that referenced this pull request Oct 7, 2024
@anthonykim1 @karthiknadig
Allow pytest to use correct interpreter from getActiveInterpreter (#2…
f9d77ab 
…4250)

Resolves: #24122
Related: #24190,
#24127

I think the culprit was we were not passing in interpreter when we call
createActivatedEnvironment.
karthiknadig pushed a commit that referenced this pull request Oct 7, 2024
@anthonykim1 @karthiknadig
Allow pytest to use correct interpreter from getActiveInterpreter (#2…
ff65066 
…4250)

Resolves: #24122
Related: #24190,
#24127

I think the culprit was we were not passing in interpreter when we call
createActivatedEnvironment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

@anthonykim1 anthonykim1

Labels

area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary

Projects

None yet

Milestone

October 2024

Development

Successfully merging this pull request may close these issues.

Test discovery with pytest fails, because pytest is run in the base conda env

2 participants

@anthonykim1 @eleanorjboyd