Skip to content

Fix: Open file browser at workspace root when selecting interpreter path #25520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −0
Draft

Fix: Open file browser at workspace root when selecting interpreter path #25520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f236b9f
Initial plan
Copilot Oct 10, 2025
549fd1a
Fix: Open file browser at workspace root when selecting interpreter path
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/client/interpreter/configuration/interpreterSelector/commands/setInterpreter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ export class SetInterpreterCommand extends BaseInterpreterSelectorCommand implem
openLabel: InterpreterQuickPickList.browsePath.openButtonLabel,
canSelectMany: false,
title: InterpreterQuickPickList.browsePath.title,
defaultUri: state.workspace,
});
if (uris && uris.length > 0) {
state.path = uris[0].fsPath;
Expand Down
23 changes: 23 additions & 0 deletions src/test/configuration/interpreterSelector/commands/setInterpreter.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,7 @@ suite('Set Interpreter Command', () => {
openLabel: InterpreterQuickPickList.browsePath.openButtonLabel,
canSelectMany: false,
title: InterpreterQuickPickList.browsePath.title,
defaultUri: undefined,
};
const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
multiStepInput.setup((i) => i.showQuickPick(TypeMoq.It.isAny())).returns(() => Promise.resolve(items[0]));
Expand All @@ -1073,6 +1074,27 @@ suite('Set Interpreter Command', () => {
openLabel: InterpreterQuickPickList.browsePath.openButtonLabel,
canSelectMany: false,
title: InterpreterQuickPickList.browsePath.title,
defaultUri: undefined,
};
multiStepInput.setup((i) => i.showQuickPick(TypeMoq.It.isAny())).returns(() => Promise.resolve(items[0]));
appShell.setup((a) => a.showOpenDialog(expectedParams)).verifiable(TypeMoq.Times.once());
platformService.setup((p) => p.isWindows).returns(() => false);

await setInterpreterCommand._enterOrBrowseInterpreterPath(multiStepInput.object, state).ignoreErrors();

appShell.verifyAll();
});

test('If `Browse...` option is selected with workspace, file browser opens at workspace root', async () => {
const workspaceUri = Uri.parse('file:///workspace/root');
const state: InterpreterStateArgs = { path: undefined, workspace: workspaceUri };
const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
const expectedParams = {
filters: undefined,
openLabel: InterpreterQuickPickList.browsePath.openButtonLabel,
canSelectMany: false,
title: InterpreterQuickPickList.browsePath.title,
defaultUri: workspaceUri,
};
multiStepInput.setup((i) => i.showQuickPick(TypeMoq.It.isAny())).returns(() => Promise.resolve(items[0]));
appShell.setup((a) => a.showOpenDialog(expectedParams)).verifiable(TypeMoq.Times.once());
Expand Down Expand Up @@ -1126,6 +1148,7 @@ suite('Set Interpreter Command', () => {
openLabel: InterpreterQuickPickList.browsePath.openButtonLabel,
canSelectMany: false,
title: InterpreterQuickPickList.browsePath.title,
defaultUri: undefined,
};
multiStepInput
.setup((i) => i.showQuickPick(TypeMoq.It.isAny()))
Expand Down