Skip to content

Add Server URI to sys info #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2018
Merged

Add Server URI to sys info #3670

merged 4 commits into from
Dec 13, 2018

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Dec 12, 2018 •
edited
Loading

For #3668

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

rchiodo
rchiodo reviewed Dec 12, 2018
View reviewed changes
rchiodo
rchiodo reviewed Dec 12, 2018
View reviewed changes
rchiodo
rchiodo reviewed Dec 12, 2018
View reviewed changes
rchiodo
rchiodo approved these changes Dec 12, 2018
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit 5eaca6b into microsoft:master Dec 13, 2018
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/addRemoteConnectInfo branch December 13, 2018 05:10
IanMatthewHuff added a commit to IanMatthewHuff/vscode-python that referenced this pull request Dec 13, 2018
@IanMatthewHuff
Add Server URI to sys info (microsoft#3670)
a37d500
@IanMatthewHuff IanMatthewHuff mentioned this pull request Dec 13, 2018
Merged
6 tasks
IanMatthewHuff added a commit that referenced this pull request Dec 13, 2018
@IanMatthewHuff
Add Server URI to sys info (#3670) (#3681)
fca6cee 
Merge master PR into release branch
#3670
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IanMatthewHuff @rchiodo