-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix multiple linter support (#2571) #3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR @nullie, and the mention @iansan5653. Looking at your work now. |
Seems good but we have some unrelated failures in tests at the moment. I'm going to add some code to quell those for the moment... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, and fixes the issue at hand. Thanks @nullie!
Taking the fix as it does address the runtime problem. However, it also re-enables a flaky test that has been pushed to a high priority item for our team this sprint. |
That was quick, I've actually made some mistakes in this and want to correct and refactor |
He acted quickly because your PR addressed a really widespread problem (#3700). Probably should just submit another PR with revisions |
For #2571
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)