Skip to content

Conversation

IanMatthewHuff
Copy link
Member

For #4140

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #4151 into master will decrease coverage by 1%.
The diff coverage is 78%.

@@           Coverage Diff           @@
##           master   #4151    +/-   ##
=======================================
- Coverage      79%     79%   -<1%     
=======================================
  Files         409     410     +1     
  Lines       18920   19259   +339     
  Branches     3063    3157    +94     
=======================================
+ Hits        14896   15089   +193     
- Misses       4021    4167   +146     
  Partials        3       3
Flag Coverage Δ
#Linux 68% <23%> (ø) ⬇️
#Windows 69% <23%> (ø) ⬇️
#macOS 68% <23%> (ø) ⬇️

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit ea6b3d5 into microsoft:master Jan 28, 2019
IanMatthewHuff added a commit that referenced this pull request Jan 28, 2019
* tests and hygiene

* new entry

* remove comment

* add directory change

* add news
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/addDirectoryChangeToNewExportCommands branch January 28, 2019 17:22
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants