Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 28, 2019

For #4168

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Jan 28, 2019
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #4169 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4169    +/-   ##
=======================================
- Coverage      79%     79%   -<1%     
=======================================
  Files         410     410            
  Lines       18970   19030    +60     
  Branches     3073    3097    +24     
=======================================
+ Hits        14936   14966    +30     
- Misses       4031    4054    +23     
- Partials        3      10     +7
Flag Coverage Δ
#Linux 69% <ø> (ø) ⬆️
#Windows 69% <ø> (+1%) ⬆️
#macOS 68% <ø> (ø) ⬇️

@rchiodo rchiodo merged commit 15ce981 into master Jan 28, 2019
rchiodo added a commit that referenced this pull request Jan 28, 2019
* Fix copy from readonly code

* Fix xmp text
@rchiodo rchiodo deleted the rchiodo/fix_copy branch February 13, 2019 15:49
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants