Skip to content

Conversation

DonJayamanne
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #4533 into master will increase coverage by 21%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4533     +/-   ##
========================================
+ Coverage      58%     78%    +21%     
========================================
  Files         367     443     +76     
  Lines       15786   20858   +5072     
  Branches     2461    3362    +901     
========================================
+ Hits         9052   16153   +7101     
+ Misses       6142    4700   -1442     
+ Partials      592       5    -587
Flag Coverage Δ
#Linux 66% <100%> (?)
#Windows 66% <100%> (?)
#macOS 66% <100%> (?)

@ericsnowcurrently ericsnowcurrently self-requested a review February 26, 2019 00:10
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Feb 26, 2019
@DonJayamanne DonJayamanne merged commit 1b55d67 into microsoft:master Feb 26, 2019
@DonJayamanne DonJayamanne deleted the fixFailedTests branch May 24, 2019 20:21
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants