Skip to content

Conversation

DonJayamanne
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [b/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #4534 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4534   +/-   ##
======================================
  Coverage      58%     58%           
======================================
  Files         367     367           
  Lines       15786   15786           
  Branches     2461    2461           
======================================
  Hits         9052    9052           
  Misses       6142    6142           
  Partials      592     592

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the grep thing on the unittest line, but otherwise g2g.

Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>
@DonJayamanne DonJayamanne merged commit c4b3ca7 into microsoft:master Feb 26, 2019
DonJayamanne added a commit that referenced this pull request Feb 26, 2019
* Fix order of icons
* Update package.json
Co-Authored-By: DonJayamanne <don.jayamanne@yahoo.com>
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants