Skip to content

Conversation

IanMatthewHuff
Copy link
Member

For #4636

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo March 4, 2019 22:41
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #4637 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4637   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         445     445           
  Lines       21076   21081    +5     
  Branches     3423    3423           
======================================
+ Hits        16216   16223    +7     
+ Misses       4854    4852    -2     
  Partials        6       6
Flag Coverage Δ
#Linux 65% <84%> (+1%) ⬆️
#Windows 66% <84%> (+1%) ⬆️
#macOS 65% <84%> (+1%) ⬆️

@IanMatthewHuff IanMatthewHuff merged commit 3e8a4ef into microsoft:master Mar 4, 2019
IanMatthewHuff added a commit that referenced this pull request Mar 5, 2019
Add telemetry for the shift enter command
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/telemetryOnShiftEnter branch July 25, 2019 23:49
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants