Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 5, 2019

For #5131

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo requested a review from IanMatthewHuff April 5, 2019 21:32
@rchiodo rchiodo self-assigned this Apr 5, 2019
@rchiodo rchiodo merged commit 7003a9b into master Apr 5, 2019
@rchiodo
Copy link
Author

rchiodo commented Apr 5, 2019

@IanMatthewHuff if you can look at this post submit, that would be great. I'm submitting it now so that the insider's build is working for a customer.

@rchiodo rchiodo deleted the rchiodo/fix_scrolling branch April 5, 2019 22:18
@IanMatthewHuff
Copy link
Member

@rchiodo . Yeah, figured that my refactor might perturb some things a bit. The scroll to bottom stuff seems a bit funky in general, but this seems like a reasonable fix for it. Thanks.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants