Skip to content

Fix magics and comments parsing #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2019
Merged

Fix magics and comments parsing #5746

merged 2 commits into from
May 24, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented May 23, 2019

For #5537

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo requested a review from IanMatthewHuff May 23, 2019 22:41
@rchiodo rchiodo self-assigned this May 23, 2019
IanMatthewHuff
IanMatthewHuff approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 34ed3fd into master May 24, 2019
@rchiodo rchiodo deleted the rchiodo/fix_latex_magic branch May 24, 2019 15:19
rchiodo added a commit that referenced this pull request May 24, 2019
@rchiodo
Fix magics and comments parsing (#5746)
6104071 
* Fix magics and comments parsing

* Fix mime types without real jupyter
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees

@rchiodo rchiodo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rchiodo @IanMatthewHuff