Skip to content

Merge a number of fixes into the release branch #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2019
Merged

Merge a number of fixes into the release branch #5777

merged 4 commits into from
May 24, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented May 24, 2019

For #5067, #5673, #5667, #5774, #5386, #5630

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo added 4 commits May 24, 2019 16:30
@rchiodo
Fix hyperlinks (#5766)
abff373
@rchiodo
Escape path names during import/export. Skip redundant chdirs (#5770)
d61802f 
* Fix security issues. Change to using less instead of sass (as it has a tar dependency)

* Fix import/export paths and remove redundant chdirs.
@rchiodo
Fix 3 bugs (#5773)
f7df23d 
Run cell moves to next cell
Ctrl+Enter keyboard shortcut
Add an empty cell
@rchiodo
Fix up/down when autocomplete is open (#5776)
3d4f49d
@rchiodo rchiodo requested a review from IanMatthewHuff May 24, 2019 23:33
@rchiodo rchiodo self-assigned this May 24, 2019
@rchiodo rchiodo merged commit 06b62a0 into release May 24, 2019
@rchiodo rchiodo deleted the rchiodo/release_merge_2 branch May 25, 2019 00:30
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees

@rchiodo rchiodo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rchiodo @IanMatthewHuff