Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jul 31, 2019

For #6729

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

kimadeline and others added 7 commits July 8, 2019 13:54
* Simplify & fix crypto.createHash
* Add tests
* Fix python test in news folder (#6398)
* Fix broken python tests in news
* Revert changes
* Enable experiment for always displaying the test explorer (#6330)

* Add logging
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 2b774ab into release Jul 31, 2019
@rchiodo rchiodo deleted the rchiodo/dataviewer_open_faster_rel branch July 31, 2019 22:14
DonJayamanne added a commit that referenced this pull request Aug 6, 2019
* release:
  Exclude .env file from extension (#6872)
  August Release (#6868)
  Cherry-pick miniconda fix into rc
  Debug Mode Code lenses (#6792)
  Make dataviewers open faster (#6795)
DonJayamanne added a commit that referenced this pull request Aug 7, 2019
* Make dataviewers open faster (#6795)

* Fix experiments hash parsing  (#6492)

* Simplify & fix crypto.createHash
* Add tests
* Fix python test in news folder (#6398)
* Fix broken python tests in news
* Revert changes

* Release cherry pick (#6515)

* Enable experiment for always displaying the test explorer (#6330)

* Add logging

* Point release - Updated package.json and CHANGELOG (#6516)

* Cherry pick change from master

* Fix npm audit

* Make dataviewers open faster

* Fix package-lock.json

* Debug Mode Code lenses (#6792)

* Cherry-pick miniconda fix into rc

* August Release (#6868)

* Exclude .env file from extension (#6872)

* Update from master

* Update package lock
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants