Skip to content

Conversation

DonJayamanne
Copy link

For #6961

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DonJayamanne DonJayamanne merged commit d24e277 into master Aug 13, 2019
DonJayamanne added a commit that referenced this pull request Aug 13, 2019
* Updated ptvsd to 4.3.2
* Update release info
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
@DonJayamanne DonJayamanne deleted the updatePTVSD branch September 29, 2019 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants