Skip to content

Conversation

karrtikr
Copy link

No description provided.

@karrtikr karrtikr added the no-changelog No news entry required label Aug 27, 2019
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #7116 into master will decrease coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7116      +/-   ##
==========================================
- Coverage   58.52%   57.77%   -0.76%     
==========================================
  Files         485      485              
  Lines       21454    21106     -348     
  Branches     3467     3462       -5     
==========================================
- Hits        12555    12193     -362     
- Misses       8122     8138      +16     
+ Partials      777      775       -2
Impacted Files Coverage Δ
.../client/datascience/jupyter/jupyterConnectError.ts 0% <0%> (-66.67%) ⬇️
...science/jupyter/jupyterKernelPromiseFailedError.ts 0% <0%> (-50%) ⬇️
...ent/datascience/jupyter/jupyterWaitForIdleError.ts 0% <0%> (-50%) ⬇️
src/client/api.ts 60% <0%> (-27.5%) ⬇️
src/client/language/characters.ts 12% <0%> (-21.34%) ⬇️
src/client/testing/codeLenses/main.ts 60% <0%> (-17.78%) ⬇️
src/client/datascience/cellFactory.ts 72.34% <0%> (-17.32%) ⬇️
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️
src/client/constants.ts 75% <0%> (-5%) ⬇️
src/client/providers/providerUtilities.ts 84.61% <0%> (-4.28%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557f25f...bf59642. Read the comment docs.

@karrtikr karrtikr merged commit 6d79704 into microsoft:master Aug 27, 2019
@karrtikr karrtikr deleted the turnLSon branch August 27, 2019 21:55
@lock lock bot locked as resolved and limited conversation to collaborators Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants