Skip to content

Conversation

kimadeline
Copy link

For #6890

@kimadeline kimadeline requested a review from karrtikr September 3, 2019 22:02
karrtikr
karrtikr approved these changes Sep 3, 2019
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #7183 into release will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #7183      +/-   ##
===========================================
- Coverage    58.48%   58.43%   -0.06%     
===========================================
  Files          485      485              
  Lines        21437    21437              
  Branches      3462     3462              
===========================================
- Hits         12537    12526      -11     
- Misses        8122     8135      +13     
+ Partials       778      776       -2
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29ca3f...00392a1. Read the comment docs.

@kimadeline kimadeline merged commit 557fbaf into microsoft:release Sep 3, 2019
@kimadeline kimadeline deleted the release-final branch September 3, 2019 22:23
kimadeline added a commit that referenced this pull request Sep 4, 2019
* add cron job to nightly tests (#7128) (#7158)
* close restart session right away (#7153) (#7161)
* close restart session right away
* ignore errors on await, don't want to stop and wait for shutdown
* Release changes (#7183)
* Update package version
DavidKutu pushed a commit that referenced this pull request Sep 9, 2019
* add cron job to nightly tests (#7128) (#7158)

* close restart session right away (#7153) (#7161)

* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown

* Release changes (#7183)

* check the position of the scroll in the interactive (#7198) (#7236)

* check the position of the scroll in the interactive
window, if it is at the bottom, the screen stays at the
bottom, and if not, the screen stays in place.
Throttling of the scroll was increased to help with
consistency on rapidly appearing plots.

* handle the scroll in the MainPanel, tested to work
with: - regular code, -dataframes, -big and regular plots.

* Added some comments.

* Turned the check of the scroll at the bottom from  … (#7259)

checking equal to checking a range to make it work with fractions.

* Preparation for point release (#7268)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants