Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Oct 1, 2019

For #7262

Basically the cancellation Token isn't checked everytime.
So even if the user were to click cancel in #7262, we'd still be doing a lot of processing.

Will implement solution for #7262 in another PR (wanted to keep this simple).

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #7714 into master will decrease coverage by 0.03%.
The diff coverage is 42.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7714      +/-   ##
==========================================
- Coverage   58.72%   58.68%   -0.04%     
==========================================
  Files         494      494              
  Lines       22027    22053      +26     
  Branches     3541     3550       +9     
==========================================
+ Hits        12935    12942       +7     
- Misses       8281     8294      +13     
- Partials      811      817       +6
Impacted Files Coverage Δ
...client/datascience/jupyter/jupyterCommandFinder.ts 69.53% <38.88%> (-4.73%) ⬇️
src/client/common/cancellation.ts 30.55% <46.66%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2862614...1662659. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Oct 1, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Oct 1, 2019

Close and open due to busted CI

@DonJayamanne DonJayamanne reopened this Oct 1, 2019
@DonJayamanne DonJayamanne marked this pull request as ready for review October 1, 2019 23:30
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit c873bbd into microsoft:master Oct 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants