Skip to content

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Oct 2, 2019

For #7733

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@karrtikr karrtikr added the no-changelog No news entry required label Oct 2, 2019
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a caveat that Don's suggestion will be taken.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought this is best refactored as a separate message (diagnostic message) such as in https://github.com/microsoft/vscode-python/blob/77e9e63486b668c673def9e0b1f98fec9bac2868/src/client/application/diagnostics/checks/powerShellActivation.ts

I know its too late, but the diagnostics messages was the preferred approach, and we seem to be deviating from that.

See other diagnostics in src/client/application/diagnostics/checks

I believe we can still do this & is best done now, for consistency.

@karrtikr
Copy link
Author

karrtikr commented Oct 3, 2019

Sorry about that, but as all the work has been done and as we've to merge this before next release, I don't think re-writing most of the stuff in the name of consistency makes much sense at this point. (also I will be OOF starting tomorrow)

However this is definitely something to keep in mind from next time onwards.
Files virtualEnvPrompt.ts, condaInheritEnvPrompt.ts, extensionSurvey.ts and more deviated from the diagnostic approach.

@ericsnowcurrently ericsnowcurrently removed their request for review October 3, 2019 15:00
@karrtikr karrtikr merged commit e1b6eb7 into microsoft:master Oct 3, 2019
@karrtikr karrtikr deleted the moreinfoConda branch October 3, 2019 17:59
@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants