Make interactive window and native editor take their fontSize and fontFamily from the settings in VS Code. #7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their fontSize and fontFamily from the settings in VS Code. We get them in nativeEditor.tsx and in interactivePanel.tsx to apply them as styles, but we also need to send them as props to eventually assign them in the monaco editor.
rchiodo
reviewed
Oct 2, 2019
rchiodo
reviewed
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #7746 +/- ##
==========================================
- Coverage 58.81% 58.43% -0.38%
==========================================
Files 496 496
Lines 22115 22158 +43
Branches 3558 3565 +7
==========================================
- Hits 13006 12948 -58
- Misses 8297 8392 +95
- Partials 812 818 +6
Continue to review full report at Codecov.
|
We now get the VS Code styles from the state of the component, instead of computing a style from an element.
rchiodo
reviewed
Oct 3, 2019
rchiodo
reviewed
Oct 3, 2019
interactivePanel, and put it in the mainStateController
DonJayamanne
reviewed
Oct 3, 2019
There was a problem hiding this comment.
I believe the react context would be a better and cleaner fit.
Tomorrow if there's another similar piece of data we'd need to modify a lot again (hypotheticaly - font color - bad example, but you get the idea)
Using a context, we don't have to modify a lot of places just to pass this information (this is contextual and doesn't change) all the way down.
react and change their fonts when the user changes them in VS Code, instead of having to reload.
rchiodo
reviewed
Oct 4, 2019
added 3 commits
October 4, 2019 16:18
two separate props to make it easier to maintain. React Context was not used to avoid making the reuse of components more difficult.
|
@DonJayamanne I ended up not using React Context, but I addressed your comment by passing an object as a prop instead of an individual value. Commit b7f514a makes that change. |
rchiodo
pushed a commit
that referenced
this pull request
Oct 10, 2019
…tFamily from the settings in VS Code. (#7746) * Make interactive window and native editor take their fontSize and fontFamily from the settings in VS Code. We get them in nativeEditor.tsx and in interactivePanel.tsx to apply them as styles, but we also need to send them as props to eventually assign them in the monaco editor. * Moved style from react code to common.css We now get the VS Code styles from the state of the component, instead of computing a style from an element. * Removed getting the font from nativeEditor and interactivePanel, and put it in the mainStateController * Made the interactiveWindow and the nativeEditor react and change their fonts when the user changes them in VS Code, instead of having to reload. * Changed the font props to be an object instead of two separate props to make it easier to maintain. React Context was not used to avoid making the reuse of components more difficult. * Removed some unnecesary passing around of the font prop * removed unnecesary comments * fixed a failing test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get them in nativeEditor.tsx and in interactivePanel.tsx
to apply them as styles, but we also need to send them
as props to eventually assign them in the monaco editor.
For #7624
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)