Skip to content

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 2, 2019

No description provided.

@karthiknadig karthiknadig added the no-changelog No news entry required label Oct 2, 2019
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #7749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7749   +/-   ##
=======================================
  Coverage   58.77%   58.77%           
=======================================
  Files         496      496           
  Lines       22141    22141           
  Branches     3567     3567           
=======================================
  Hits        13013    13013           
  Misses       8310     8310           
  Partials      818      818

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c873bbd...008e15f. Read the comment docs.

@karthiknadig
Copy link
Member Author

Waiting till I get the confirmation from CELA on which license to use in the case of packaging.

@karthiknadig karthiknadig merged commit 87e23e2 into microsoft:master Oct 3, 2019
@brettcannon
Copy link
Member

@karthiknadig tentatively they said BSD-2, so we can do that for now and change if necessary later.

karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2019
@karthiknadig karthiknadig deleted the packages branch November 1, 2019 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants