Fix liveshare guest hang issue #7764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Oct 4, 2019
| return result; | ||
| } | ||
|
|
||
| public async onSessionChange(api: vsls.LiveShare | null): Promise<void> { |
There was a problem hiding this comment.
Rich, I'm a bit unsure if the guest role needs this. It makes sense structurally to me, but is not needed for this fix.
There was a problem hiding this comment.
IanMatthewHuff
commented
Oct 4, 2019
| verifyHtmlOnCell(guestContainer.wrapper!, 'InteractiveCell', '<span>1</span>', CellPosition.Last); | ||
| }); | ||
|
|
||
| test('Host starts LiveShare after starting Jupyter', async() => { |
There was a problem hiding this comment.
Verified this test fails with a hang of the guest connection to the host without my fix, and passes with my fix.
|
My internet works again :P |
Codecov Report
@@ Coverage Diff @@
## master #7764 +/- ##
==========================================
- Coverage 58.78% 58.43% -0.35%
==========================================
Files 496 496
Lines 22146 22157 +11
Branches 3568 3565 -3
==========================================
- Hits 13018 12947 -71
- Misses 8310 8392 +82
Partials 818 818
Continue to review full report at Codecov.
|
IanMatthewHuff
added a commit
to IanMatthewHuff/vscode-python
that referenced
this pull request
Oct 4, 2019
* initial changes * update notebooks on server session change and add test * await correctly
IanMatthewHuff
added a commit
that referenced
this pull request
Oct 4, 2019
rchiodo
pushed a commit
that referenced
this pull request
Oct 10, 2019
* initial changes * update notebooks on server session change and add test * await correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7638
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)