Fix jupyter server startup hang when xeus-cling is installed #7773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKutu
approved these changes
Oct 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #7773 +/- ##
==========================================
+ Coverage 58.43% 58.43% +<.01%
==========================================
Files 496 496
Lines 22157 22158 +1
Branches 3565 3565
==========================================
+ Hits 12947 12948 +1
Misses 8392 8392
Partials 818 818
Continue to review full report at Codecov.
|
…eter_timeout_master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7569
For some reason when we search for python interpreters we're finding something that isn't a python executable. Launching this executable to ask if it's a python executable can hang if the executable doesn't throw an error. Adding a five second timeout to handle this case.