Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Oct 4, 2019

We should have done this a while ago, but this setting enables the notebook editor for everyone by default.

@rchiodo rchiodo added the no-changelog No news entry required label Oct 4, 2019
@rchiodo rchiodo self-assigned this Oct 4, 2019
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #7777 into release will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #7777      +/-   ##
===========================================
+ Coverage    58.08%   58.78%   +0.69%     
===========================================
  Files          496      496              
  Lines        21765    22126     +361     
  Branches      3555     3560       +5     
===========================================
+ Hits         12643    13006     +363     
+ Misses        8310     8308       -2     
  Partials       812      812
Impacted Files Coverage Δ
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/dotnet/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/linters/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/platform/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c9206...c27b4d9. Read the comment docs.

@rchiodo rchiodo merged commit d9523e0 into release Oct 4, 2019
@rchiodo rchiodo deleted the rchiodo/enable_editor branch October 4, 2019 21:10
@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants