Interactive Window and Native Editor react to font changes in VS Code settings #7799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 7, 2019 12:45
their fontSize and fontFamily from the settings in VS Code. We get them in nativeEditor.tsx and in interactivePanel.tsx to apply them as styles, but we also need to send them as props to eventually assign them in the monaco editor.
We now get the VS Code styles from the state of the component, instead of computing a style from an element.
interactivePanel, and put it in the mainStateController
react and change their fonts when the user changes them in VS Code, instead of having to reload.
two separate props to make it easier to maintain. React Context was not used to avoid making the reuse of components more difficult.
Codecov Report
@@ Coverage Diff @@
## release #7799 +/- ##
========================================
Coverage 58.78% 58.78%
========================================
Files 496 496
Lines 22126 22126
Branches 3560 3560
========================================
Hits 13006 13006
Misses 8308 8308
Partials 812 812
Continue to review full report at Codecov.
|
rchiodo
approved these changes
Oct 7, 2019
IanMatthewHuff
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already in master. Making this PR in case we include this in the next release.
For #7624
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)