More functional tests for the notebook editor #7804
Conversation
Make sure when an error occurs on running a cell it's displayed to the user.
Codecov Report
@@ Coverage Diff @@
## master #7804 +/- ##
==========================================
+ Coverage 59.15% 59.15% +<.01%
==========================================
Files 498 498
Lines 22254 22256 +2
Branches 3578 3579 +1
==========================================
+ Hits 13164 13166 +2
Misses 8266 8266
Partials 824 824
Continue to review full report at Codecov.
|
| await this.errorHandler.handleError(exc); | ||
|
|
||
| // Make this error our cell output | ||
| this.sendCellsToWebView([ |
There was a problem hiding this comment.
Why not send the error message to the view then display the error message (e.g. errorHandler.handleError could end up displaying another UI, and its good to have the errors already visible in the native editor at that point.
There was a problem hiding this comment.
| } | ||
|
|
||
| public resetLoad() { | ||
| this.waitingForLoadRender = false; |
There was a problem hiding this comment.
Rests the state of loading so that the tests can reload the same control over again. I'll add a comment. reset sounds like a better name
In reply to: 332271637 [](ancestors = 332271637)
| export function closeNotebook(editor: INotebookEditor, wrapper: ReactWrapper<any, Readonly<{}>, React.Component>): Promise<void> { | ||
| const reactEditor = getMainPanel<NativeEditor>(wrapper, NativeEditor); | ||
| if (reactEditor) { | ||
| reactEditor.stateController.resetLoad(); |
There was a problem hiding this comment.
If we're closing an editor, then why call it resetLoad, why not reset or dispose?
There was a problem hiding this comment.
dispose isn't appropriate as the react control is still active. But reset works.
In reply to: 332272623 [](ancestors = 332272623)
* New tests * Add some more functional tests for the notebook editor Make sure when an error occurs on running a cell it's displayed to the user. * Review feedback
3 participants
For #7372
Provide some error checking around server not running.
Also fixed the code so that if an error occurs during startup, we show the error in the output of the first cell.