Add native command palette cell commands and recontext IW cell commands #7807
Conversation
| this.submitInput(concatMultilineString(selectedCell.cell.data.source), selectedCell); | ||
| } | ||
| } | ||
| this.resumeUpdates(); |
There was a problem hiding this comment.
resumeUpdates [](start = 13, length = 13)
I don't think we need this around submission of input. This is really just suspend state updates. Doesn't seem necessary here. #Resolved
There was a problem hiding this comment.
Would it not be needed in the existing runAll code? Or do we need it there because we might be doing it for multiple cells?
In reply to: 332283022 [](ancestors = 332283022)
There was a problem hiding this comment.
Yeah it's for multiple cells. It basically postpones any state updates until resumeUpdates get called, meaning no renders happen. It doesn't really hurt here though. You could just leave it to be consistent.
In reply to: 332284555 [](ancestors = 332284555,332283022)
There was a problem hiding this comment.
Nah, if it's not needed it's not needed. I was just copying the "only one" case from run all. I'll remove it.
In reply to: 332285496 [](ancestors = 332285496,332284555,332283022)
| "when": "python.datascience.havenative && python.datascience.featureenabled" | ||
| }, | ||
| { | ||
| "command": "python.datascience.notebookeditor.runselectedcell", |
There was a problem hiding this comment.
runselectedcell [](start = 66, length = 15)
Does this need a check to see if there is a selected cell? #Resolved
There was a problem hiding this comment.
Yeah, it doesn't really do anything without that. I'll add it into the send info and have a context for it.
In reply to: 332283220 [](ancestors = 332283220)
Codecov Report
@@ Coverage Diff @@
## master #7807 +/- ##
==========================================
- Coverage 59.16% 59.16% -0.01%
==========================================
Files 498 498
Lines 22254 22266 +12
Branches 3578 3580 +2
==========================================
+ Hits 13166 13173 +7
- Misses 8264 8269 +5
Partials 824 824
Continue to review full report at Codecov.
|
3 participants
For #7800
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)