Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the language server to choose its default caching mode #7822

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@jakebailey
Copy link
Member

commented Oct 8, 2019

For #7821

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
@codecov-io

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #7822 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7822   +/-   ##
=======================================
  Coverage   59.25%   59.25%           
=======================================
  Files         498      498           
  Lines       22293    22293           
  Branches     3580     3580           
=======================================
  Hits        13209    13209           
  Misses       8262     8262           
  Partials      822      822

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c5607...13df376. Read the comment docs.

@karthiknadig karthiknadig merged commit 5e9eaaf into microsoft:master Oct 8, 2019
20 checks passed
20 checks passed
PR Validation Build #2019.10.0.40956-pr succeeded
Details
PR Validation (Build Build) Build Build succeeded
Details
PR Validation (Build Compile) Build Compile succeeded
Details
PR Validation (Build Hygiene) Build Hygiene succeeded
Details
PR Validation (Reports Coverage) Reports Coverage succeeded
Details
PR Validation (Smoke Smoke Linux-Py3.7) Smoke Smoke Linux-Py3.7 succeeded
Details
PR Validation (Smoke Smoke Mac-Py3.7) Smoke Smoke Mac-Py3.7 succeeded
Details
PR Validation (Smoke Smoke Win-Py3.7) Smoke Smoke Win-Py3.7 succeeded
Details
PR Validation (Tests Test Linux-Py2.7 Unit+Single) Tests Test Linux-Py2.7 Unit+Single succeeded
Details
PR Validation (Tests Test Linux-Py3.7 Functional) Tests Test Linux-Py3.7 Functional succeeded
Details
PR Validation (Tests Test Linux-Py3.7 Single Workspace) Tests Test Linux-Py3.7 Single Workspace succeeded
Details
PR Validation (Tests Test Linux-Py3.7 Unit) Tests Test Linux-Py3.7 Unit succeeded
Details
PR Validation (Tests Test Mac-Py2.7 Unit+Single) Tests Test Mac-Py2.7 Unit+Single succeeded
Details
PR Validation (Tests Test Mac-Py3.7 Single Workspace) Tests Test Mac-Py3.7 Single Workspace succeeded
Details
PR Validation (Tests Test Mac-Py3.7 Unit) Tests Test Mac-Py3.7 Unit succeeded
Details
PR Validation (Tests Test Win-Py2.7 Unit) Tests Test Win-Py2.7 Unit succeeded
Details
PR Validation (Tests Test Win-Py3.7 Unit) Tests Test Win-Py3.7 Unit succeeded
Details
SonarCloud Code Analysis Quality Gate passed
Details
license/cla All CLA requirements met.
Details
pvscbot/news news entry file found
Details
@jakebailey jakebailey deleted the jakebailey:default-caching branch Oct 8, 2019
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Oct 8, 2019
karthiknadig added a commit that referenced this pull request Oct 8, 2019
* Allow the language server to choose its default caching mode (#7822)
* Preparing for release
* Update to change logs
* Grammar and typo fixes.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.