Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Oct 8, 2019

For #7693

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #7831 into master will increase coverage by 0.68%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7831      +/-   ##
==========================================
+ Coverage   58.57%   59.25%   +0.68%     
==========================================
  Files         498      498              
  Lines       21934    22295     +361     
  Branches     3575     3580       +5     
==========================================
+ Hits        12847    13211     +364     
+ Misses       8265     8262       -3     
  Partials      822      822
Impacted Files Coverage Δ
src/client/datascience/webViewHost.ts 11.11% <ø> (ø) ⬆️
src/client/common/application/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <100%> (ø) ⬆️
src/client/common/application/applicationShell.ts 15% <50%> (-0.79%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221b8b3...0e366e7. Read the comment docs.

@DonJayamanne DonJayamanne marked this pull request as ready for review October 9, 2019 16:14
@DonJayamanne DonJayamanne requested review from DavidKutu, IanMatthewHuff, karrtikr and rchiodo and removed request for karrtikr October 9, 2019 16:14
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@DonJayamanne DonJayamanne requested a review from rchiodo October 9, 2019 22:10
@DonJayamanne
Copy link
Author

@rchiodo Please re-review when possible.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit c5cb1ef into microsoft:master Oct 10, 2019
rchiodo pushed a commit that referenced this pull request Oct 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
@DonJayamanne DonJayamanne deleted the autoSaveNotebook branch December 17, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants