Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Oct 9, 2019

Component governance is flagging this dependency as needing more info. We don't actually need it, so removing it.

@rchiodo rchiodo added the no-changelog No news entry required label Oct 9, 2019
@rchiodo rchiodo self-assigned this Oct 9, 2019
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #7863 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7863      +/-   ##
==========================================
+ Coverage   59.24%   59.25%   +<.01%     
==========================================
  Files         498      498              
  Lines       22293    22293              
  Branches     3580     3580              
==========================================
+ Hits        13208    13210       +2     
+ Misses       8263     8261       -2     
  Partials      822      822
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 88.23% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac8da2...94af7b7. Read the comment docs.

@rchiodo rchiodo closed this Oct 9, 2019
@rchiodo rchiodo reopened this Oct 9, 2019
@rchiodo rchiodo merged commit 4a2a0d5 into master Oct 10, 2019
@rchiodo rchiodo deleted the rchiodo/remove_unused_dependencies branch October 10, 2019 00:24
rchiodo added a commit that referenced this pull request Oct 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants