Skip to content

Conversation

DonJayamanne
Copy link

For #7905

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #7921 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7921      +/-   ##
==========================================
+ Coverage   58.94%   59.26%   +0.31%     
==========================================
  Files         498      499       +1     
  Lines       22299    22400     +101     
  Branches     3576     3593      +17     
==========================================
+ Hits        13144    13275     +131     
+ Misses       8333     8299      -34     
- Partials      822      826       +4
Impacted Files Coverage Δ
...ascience/interactive-ipynb/nativeEditorProvider.ts 58.51% <100%> (ø)
...debugger/extension/configuration/resolvers/base.ts 88.4% <0%> (-2.9%) ⬇️
src/client/datascience/constants.ts 100% <0%> (ø) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <0%> (ø) ⬆️
src/datascience-ui/interactive-common/mainState.ts 46% <0%> (+1.1%) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ce843...5e2175a. Read the comment docs.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 6315050 into microsoft:master Oct 14, 2019
DonJayamanne added a commit that referenced this pull request Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2019
@DonJayamanne DonJayamanne deleted the issue7905 branch April 30, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants