Skip to content

Conversation

IanMatthewHuff
Copy link
Member

For #7888

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #7981 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7981      +/-   ##
==========================================
- Coverage   59.26%   58.61%   -0.66%     
==========================================
  Files         499      499              
  Lines       22400    22813     +413     
  Branches     3593     3770     +177     
==========================================
+ Hits        13275    13371      +96     
- Misses       8299     8613     +314     
- Partials      826      829       +3
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterExporter.ts 15.46% <0%> (-3.99%) ⬇️
src/client/datascience/cellFactory.ts 86.84% <0%> (-2.82%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 5.02% <0%> (-1.06%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 5.85% <0%> (-0.38%) ⬇️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/datascience/common.ts 93.52% <0%> (+0.5%) ⬆️
src/datascience-ui/interactive-common/mainState.ts 50% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6315050...e0b6972. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 0ad39cd into microsoft:master Oct 15, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/newNotebookCommand branch October 15, 2019 16:40
@lock lock bot locked as resolved and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants