Do not auto save if notebook is untitled

src/client/datascience/interactive-ipynb/autoSaveService.ts

@@ -120,7 +120,7 @@ export class AutoSaveService implements IInteractiveWindowListener {
     private save() {
         this.clearTimeout();
         const notebook = this.getNotebook();
-        if (notebook && notebook.isDirty) {
+        if (notebook && notebook.isDirty && !notebook.isUntitled) {
             // Notify webview to perform a save.
             this.postEmitter.fire({ message: InteractiveWindowMessages.DoSave, payload: undefined });
         } else {

src/client/datascience/interactive-ipynb/nativeEditor.ts

@@ -151,6 +151,10 @@ export class NativeEditor extends InteractiveBase implements INotebookEditor {
         return this._file;
     }
 
+    public get isUntitled(): boolean {
+        const baseName = path.basename(this.file.fsPath);
+        return baseName.includes(localize.DataScience.untitledNotebookFileName());
+    }
     public dispose(): void {
         super.dispose();
         this.close().ignoreErrors();
@@ -713,18 +717,15 @@ export class NativeEditor extends InteractiveBase implements INotebookEditor {
             let isDirty = this._dirty;
 
             // Ask user for a save as dialog if no title
-            const baseName = path.basename(this.file.fsPath);
-            const isUntitled = baseName.includes(localize.DataScience.untitledNotebookFileName());
-            if (isUntitled) {
+            if (this.isUntitled) {
                 const filtersKey = localize.DataScience.dirtyNotebookDialogFilter();
                 const filtersObject: { [name: string]: string[] } = {};
                 filtersObject[filtersKey] = ['ipynb'];
                 isDirty = true;
 
                 fileToSaveTo = await this.applicationShell.showSaveDialog({
                     saveLabel: localize.DataScience.dirtyNotebookDialogTitle(),
-                    filters: filtersObject,
-                    defaultUri: isUntitled ? undefined : this.file
+                    filters: filtersObject
                 });
             }
 

src/client/datascience/types.ts

@@ -251,6 +251,10 @@ export interface INotebookEditor extends IInteractiveBase {
     executed: Event<INotebookEditor>;
     modified: Event<INotebookEditor>;
     saved: Event<INotebookEditor>;
+    /**
+     * Is this notebook representing an untitled file which has never been saved yet.
+     */
+    readonly isUntitled: boolean;
     /**
      * `true` if there are unpersisted changes.
      */