Fix cells being erased when saving and then changing focus to another… #8482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is high priority, so I'll be porting this over to the release branch too. |
DavidKutu
approved these changes
Nov 9, 2019
| const newVMs = [...this.pendingState.cellVMs]; | ||
| for (let i = 0; i < newVMs.length; i += 1) { | ||
| const text = this.getMonacoEditorContents(newVMs[i].cell.id); | ||
| if (text) { |
There was a problem hiding this comment.
Does this bit work if you delete the text to empty out the string? If I'm reading it right you could delete the text, the '' would be falsy and not saved?
There was a problem hiding this comment.
Yeah I think you're right. I should check for undefined, not falsy
In reply to: 344416085 [](ancestors = 344416085)
Codecov Report
@@ Coverage Diff @@
## master #8482 +/- ##
=========================================
- Coverage 59.39% 59.09% -0.3%
=========================================
Files 509 510 +1
Lines 23422 23561 +139
Branches 3786 3813 +27
=========================================
+ Hits 13912 13924 +12
- Misses 8604 8729 +125
- Partials 906 908 +2
Continue to review full report at Codecov.
|
rchiodo
added a commit
that referenced
this pull request
Nov 9, 2019
#8482) * Fix cells being erased when saving and then changing focus to another cell * Make sure to use the source even if it's empty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… cell
For #8399
Root cause here is we were updating the state in line instead of calling setState.
Redux refactor would have fixed this as well.