Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Nov 14, 2019

For #7999

CTRL+Z was not being checked separately from just plain 'Z'

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #8571 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8571      +/-   ##
==========================================
+ Coverage   58.72%   59.07%   +0.34%     
==========================================
  Files         511      511              
  Lines       23328    23699     +371     
  Branches     3829     3829              
==========================================
+ Hits        13700    14000     +300     
- Misses       8709     8780      +71     
  Partials      919      919
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100% <100%> (ø) ⬆️
src/client/testing/serviceRegistry.ts 48.64% <0%> (-44.21%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 66.66% <0%> (-33.34%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 75% <0%> (-25%) ⬇️
src/client/common/utils/icons.ts 83.33% <0%> (-16.67%) ⬇️
src/client/testing/codeLenses/main.ts 44.44% <0%> (-15.56%) ⬇️
src/client/api.ts 78.57% <0%> (-11.43%) ⬇️
src/client/common/utils/version.ts 77.77% <0%> (-1.39%) ⬇️
src/client/providers/providerUtilities.ts 83.33% <0%> (-1.29%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3b14e...6363323. Read the comment docs.

@rchiodo rchiodo merged commit 396b2f6 into master Nov 14, 2019
@rchiodo rchiodo deleted the rchiodo/7999_ctrl_z branch November 14, 2019 01:45
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants