Skip to content

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Nov 14, 2019

For #8495

Monaco doesn't sort the view lines when it creates them, messing up our computation for figuring out the current line using the offset of the cursor.

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #8587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8587   +/-   ##
=======================================
  Coverage   59.43%   59.43%           
=======================================
  Files         512      512           
  Lines       23757    23757           
  Branches     3842     3842           
=======================================
  Hits        14120    14120           
  Misses       8713     8713           
  Partials      924      924

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5d7f5...016506b. Read the comment docs.

@rchiodo rchiodo merged commit 9b4cb1d into master Nov 14, 2019
@rchiodo rchiodo deleted the rchiodo/8495_paste_arrowupdown branch November 14, 2019 22:28
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants