Skip to content

Conversation

luabud
Copy link
Member

@luabud luabud commented Dec 5, 2019

MERGE ONLY AFTER RELEASE

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing

@luabud luabud added the no-changelog No news entry required label Dec 5, 2019
@brettcannon brettcannon mentioned this pull request Dec 5, 2019
64 tasks
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #8913 into master will not change coverage.
The diff coverage is 54.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8913   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files         529      529           
  Lines       28578    28578           
  Branches     4338     4338           
=======================================
  Hits        17413    17413           
  Misses      10214    10214           
  Partials      951      951
Impacted Files Coverage Δ
src/client/common/application/types.ts 100% <ø> (ø) ⬆️
src/client/common/terminal/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/activation.ts 93.54% <ø> (ø) ⬆️
src/client/datascience/data-viewing/types.ts 100% <ø> (ø) ⬆️
src/client/common/dotnet/serviceRegistry.ts 100% <ø> (ø) ⬆️
src/client/common/installer/types.ts 100% <ø> (ø) ⬆️
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/common/process/types.ts 100% <ø> (ø) ⬆️
src/client/common/dotnet/types.ts 100% <ø> (ø) ⬆️
...ence/interactive-common/intellisense/wordHelper.ts 19.35% <0%> (ø) ⬆️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d696cb...e3405a6. Read the comment docs.

@luabud
Copy link
Member Author

luabud commented Dec 6, 2019

image

@kimadeline
Copy link

Update #9320 after this gets merged

@karthiknadig
Copy link
Member

@luabud Merge this when you are ready.

@luabud luabud marked this pull request as ready for review January 7, 2020 20:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@luabud luabud merged commit 734193b into microsoft:master Jan 8, 2020
@luabud luabud deleted the debugexperimentchanges branch January 8, 2020 14:21
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants