Make sure to leave the loop if switching works. #9239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9239 +/- ##
=========================================
- Coverage 57.5% 57.5% -0.01%
=========================================
Files 551 551
Lines 29433 29434 +1
Branches 4461 4461
=========================================
Hits 16925 16925
- Misses 11561 11562 +1
Partials 947 947
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Dec 20, 2019
| while (true) { | ||
| try { | ||
| await this.switchKernel(kernel); | ||
| break; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching a kernel is stuck in an infinite loop.