Skip to content

When checking if kernelspec subcommand is available, use subprocess #9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2020
Merged

When checking if kernelspec subcommand is available, use subprocess #9400

merged 4 commits into from
Jan 6, 2020

Conversation

DonJayamanne
Copy link

No description provided.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 6, 2020
rchiodo
rchiodo previously approved these changes Jan 6, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Jan 6, 2020 •
edited
Loading

Codecov Report

Merging #9400 into release-2019.12 will decrease coverage by 0.36%.
The diff coverage is 25%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2019.12    #9400      +/-   ##
===================================================
- Coverage            57.38%   57.01%   -0.37%     
===================================================
  Files                  551      551              
  Lines                29396    29420      +24     
  Branches              4468     4473       +5     
===================================================
- Hits                 16868    16775      -93     
- Misses               11583    11706     +123     
+ Partials               945      939       -6
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterCommand.ts 53.92% <25%> (-15.31%) ⬇️
src/client/testing/serviceRegistry.ts 49.09% <0%> (-47.28%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-30%) ⬇️
src/datascience-ui/interactive-common/tokenizer.ts 35% <0%> (-30%) ⬇️
src/client/datascience/jupyter/jupyterUtils.ts 64.7% <0%> (-29.42%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 50% <0%> (-25%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/native-editor/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/history-react/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 37.5% <0%> (-25%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2346d0...eb25258. Read the comment docs.

@rchiodo rchiodo self-requested a review January 6, 2020 19:24
@rchiodo rchiodo dismissed their stale review January 6, 2020 19:25

revoking review

rchiodo
rchiodo previously approved these changes Jan 6, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne requested a review from rchiodo January 6, 2020 20:25
@rchiodo rchiodo dismissed their stale review January 6, 2020 20:31

revoking review

rchiodo
rchiodo approved these changes Jan 6, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 04587ed into release-2019.12 Jan 6, 2020
DonJayamanne added a commit that referenced this pull request Jan 6, 2020
@DonJayamanne
When checking if kernelspec subcommand is available, use subprocess (…
16ff5bc 
…#9400)

* When checking if `kernelspec` subcommand is available, use subprocess
* Ignore linter error
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DonJayamanne @codecov-io @IanMatthewHuff @rchiodo