More places in DS code to bypass conda run #9467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
karthiknadig and
rchiodo
DavidKutu
approved these changes
Jan 9, 2020
DonJayamanne
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
approved these changes
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #9467 +/- ##
=======================================
Coverage 60.91% 60.91%
=======================================
Files 530 530
Lines 28650 28650
Branches 4344 4344
=======================================
Hits 17452 17452
Misses 10245 10245
Partials 953 953
Continue to review full report at Codecov.
|
DonJayamanne
added a commit
that referenced
this pull request
Jan 9, 2020
For #9444 Found two more places where we could end up using conda run. Bypass this as well to ensure we use activated environment variables instead, we know this is guaranteed to work. This is all that's remaining as far as I know where DS code is using conda run. We know at least from one user that conda run has failed to get list of kernels.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9444
Found two more places where we could end up using
conda run.Bypass this as well to ensure we use
activated environmentvariables instead, we know this is guaranteed to work.This is all that's remaining as far as I know where DS code is using
conda run.We know at least from one user that
conda runhas failed to get list of kernels.