Skip to content

Conversation

kimadeline
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

* Revert "fix(client/linters/mypy): call mypy incorrectly (microsoft#5834)"
This reverts commit 1b6fbfb.
* News file
* Revert "Fix MyPy CI tests (microsoft#8518)"
This reverts commit c634ffd.
* Disable conda execution service instantiation
* News file
* Didn't mean to commit that
* Forgot a few tests
* Linting
* Update comment
@kimadeline kimadeline added the no-changelog No news entry required label Jan 10, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-2019.12@ff4f124). Click here to learn what that means.
The diff coverage is 43.18%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release-2019.12    #9530   +/-   ##
==================================================
  Coverage                   ?   57.25%           
==================================================
  Files                      ?      551           
  Lines                      ?    29425           
  Branches                   ?     4475           
==================================================
  Hits                       ?    16846           
  Misses                     ?    11632           
  Partials                   ?      947
Impacted Files Coverage Δ
...client/datascience/jupyter/jupyterCommandFinder.ts 71.22% <ø> (ø)
...rc/client/common/application/webPanels/webPanel.ts 15.87% <ø> (ø)
src/client/common/process/types.ts 100% <ø> (ø)
src/client/datascience/constants.ts 99.68% <100%> (ø)
src/client/datascience/jupyter/notebookStarter.ts 71.54% <100%> (ø)
src/client/terminals/codeExecution/repl.ts 100% <100%> (ø)
...t/terminals/codeExecution/terminalCodeExecution.ts 100% <100%> (ø)
...rc/client/common/process/pythonExecutionFactory.ts 96.29% <100%> (ø)
...erminals/codeExecution/djangoShellCodeExecution.ts 100% <100%> (ø)
...lient/datascience/jupyter/kernels/kernelService.ts 56.08% <24%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4f124...b41a1ad. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline kimadeline merged commit 6895143 into microsoft:release-2019.12 Jan 10, 2020
@kimadeline kimadeline deleted the cherry-pick-conda-mypy branch January 10, 2020 19:22
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants