Skip to content

Conversation

DonJayamanne
Copy link

For #9927

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 5, 2020
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #9936 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9936      +/-   ##
=========================================
- Coverage    61.2%   61.2%   -0.01%     
=========================================
  Files         564     564              
  Lines       30061   30077      +16     
  Branches     4545    4550       +5     
=========================================
+ Hits        18399   18408       +9     
- Misses      10632   10639       +7     
  Partials     1030    1030
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterServer.ts 8.33% <0%> (ø) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 11.11% <0%> (-1.25%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 16.96% <0%> (ø) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 56.98% <100%> (+0.27%) ⬆️
...client/datascience/jupyter/jupyterServerWrapper.ts 30.23% <33.33%> (+1.66%) ⬆️
...lient/datascience/jupyter/liveshare/serverCache.ts 65.33% <0%> (-0.43%) ⬇️
src/client/common/process/proc.ts 15.21% <0%> (+0.72%) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (+1.56%) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (+2.22%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7618f...1eab1d9. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit 143e592 into microsoft:master Feb 6, 2020
@DonJayamanne DonJayamanne deleted the fixAutoStartDefaultKernel branch February 6, 2020 00:32
DonJayamanne added a commit that referenced this pull request Feb 6, 2020
For #9927
* Notebook should use kernel from metadata
* Fix formatting
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants